refactor(cmd): use resty.signal for process signaling #11621
+727
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a large refactor of this module in the pipeline, and renaming from 'kill' to 'process' makes the API more sensible.
This is another name-only change ahead of some larger refactoring of the kong.cmd.utils.process module.
This refactors kong.cmd.utils.process to use the resty.signal library for sending signals instead of dropping to a shell. This comes with improvements (albeit minor) to performance and security.
hanshuebner
changed the title
|
I'm reverting this to draft until we can also confirm that the |
|
This PR is marked as stale because it has been open for 14 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary improvements:
os.execute()for sending signalsSome months ago I needed to look over the code in
kong/cmd/utils/kill.luaand thought to myself "we can do better than os.execute() here." At long last, here are the improvements that stemmed from that thought.Along the way I renamed the file to
kong/cmd/utils/process.luaand changed the name of theis_running()function toexists()for aesthetic reasons. This and the other API changes to the file make the PR somewhat large, but these changes were done in separate commits, so review commit-by-commit if you want to have an easier read-through of the changes.There was a flaky test in
spec/02-integration/01-helpers/03-http_mock_spec.luathat was giving me trouble. It was actually related to this problem domain (waiting for a pidfile to exist and contain a PID), so I fixed it here as well.Re-do #11382 without squashing, merge after #11620