-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jwt): remove chances to base64 decode a rsa_public_key #13717
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @jizhilong! The fix looks good to me. @bungle could you also take a look?
changelog/unreleased/kong/fix-jwt-plugin-rsa-public-key-b64decoded
Outdated
Show resolved
Hide resolved
changelog/unreleased/kong/fix-jwt-plugin-rsa-public-key-b64decoded.yml
Outdated
Show resolved
Hide resolved
Successfully created cherry-pick PR for |
@jizhilong please claim your Kong Contributor digital badge over here https://docs.google.com/forms/d/e/1FAIpQLSfacQHac-PYIDIrDOi_W2l7cWxBDRIVBs6xE5HnlojPvdhL9g/viewform. |
I guess this PR breaks current running gateways already deployed with base64-encoded keys. |
|
Summary
never base64 decode a rsa public key
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.md[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
Fix #13710