-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clustering): CP should support both v1 and v2 #13805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Oct 29, 2024
team-gateway-bot
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Oct 29, 2024
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
October 30, 2024 07:23
9bc6321
to
0c55600
Compare
StarlightIbuki
changed the title
fix(clustering): avoid 500 accessing v1 api when inc_sync enabled
fix(clustering): CP should support v1
Oct 30, 2024
chronolaw
reviewed
Oct 30, 2024
StarlightIbuki
commented
Oct 31, 2024
StarlightIbuki
commented
Oct 31, 2024
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
5 times, most recently
from
October 31, 2024 07:24
6fb6360
to
ad5a0c5
Compare
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
3 times, most recently
from
October 31, 2024 07:33
1d10000
to
9a27cab
Compare
chronolaw
reviewed
Oct 31, 2024
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
October 31, 2024 09:36
9a27cab
to
cd7ac7c
Compare
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
3 times, most recently
from
October 31, 2024 09:44
a8ed69f
to
14c47ef
Compare
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
October 31, 2024 09:46
14c47ef
to
dcfc998
Compare
StarlightIbuki
changed the base branch from
master
to
refactor/tuning_inc_sync
October 31, 2024 09:46
chronolaw
force-pushed
the
refactor/tuning_inc_sync
branch
from
October 31, 2024 09:48
f35c3d3
to
63c17e2
Compare
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
October 31, 2024 09:49
dcfc998
to
9b464bf
Compare
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
November 4, 2024 03:06
9b464bf
to
5791783
Compare
chronolaw
approved these changes
Nov 4, 2024
3 tasks
chronolaw
changed the title
fix(clustering): CP should support v1
fix(clustering): CP should support both v1 and v2
Nov 4, 2024
team-eng-enablement
removed
the
author/community
PRs from the open-source community (not Kong Inc)
label
Nov 4, 2024
chobits
approved these changes
Nov 5, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13805-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13805-to-master-to-upstream
git checkout -b cherry-pick-13805-to-master-to-upstream
ancref=$(git merge-base 0072d7b770af30d6f3373ed6e6d39955b1c78090 5791783c811a692233957866b0753dd8d088378a)
git cherry-pick -x $ancref..5791783c811a692233957866b0753dd8d088378a |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Nov 5, 2024
We will cherry-pick after a larger cherry-pick is done: https://github.com/Kong/kong-ee/pull/10460 |
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/admin-api
core/clustering
core/pdk
plugins/loggly
size/M
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's fix the rest of the tests in another PR.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5551