-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(hybrid): enable cluster sync in test case 11-status_spec.lua #13985
base: master
Are you sure you want to change the base?
Conversation
@@ -119,7 +116,10 @@ for _, strategy in helpers.each_strategy() do | |||
|
|||
local status = res and res.status | |||
http_client:close() | |||
if status == 200 then | |||
|
|||
if (inc_sync == "on" and status == 503) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could work but may not the best solution, since the case title is "should return 200 on data plane after configuring"
, and the status code is 503
when enabling inc_sync.
@@ -138,7 +138,9 @@ for _, strategy in helpers.each_strategy() do | |||
|
|||
local status = res and res.status | |||
http_client:close() | |||
if status == 200 then | |||
if (inc_sync == "on" and status == 503) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before inserting an entity, it will return 503.
After inserting an entity, which makes the configuration non-empty, it will return 200.
The inserting-an-entity case is not added to this case currently.
It also needs to add a test case that, when we insert a service, the DP status will become ready, like the following, but after CP restarts, inserted entity could not notify DP with RPC concentrator since there's a concentrator connection timeout bug: https://konghq.atlassian.net/browse/KAG-5994
|
Summary
Currently, we are verifying that the
/ready/status
endpoint with an empty config in cluster sync mode returns a 503.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5974