-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(clustering/rpc): post event when rpc is ready #14034
Conversation
33bae64
to
d28754b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a disconnection notification? And what about CP's side notification for new DP connection?
I think that CP side does not need notification now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start! However, we need more work to be done for [KAG-5891] to be considered done because we also need to receive notifications when connections are broken and stop syncing. But that can be done in another PR.
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-14034-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-14034-to-master-to-upstream
git checkout -b cherry-pick-14034-to-master-to-upstream
ancref=$(git merge-base 33a43c702c81c0ff0e6090f6f95faec30a65a5b7 186e40827fa5b9f0902e6b03738c7a581b661799)
git cherry-pick -x $ancref..186e40827fa5b9f0902e6b03738c7a581b661799 |
@StarlightIbuki could you open some new PR for KAG-5891, based on this PR? |
-- if rpc is ready we will check then decide how to sync | ||
worker_events.register(function(capabilities_list) | ||
-- we only check once | ||
if self.inited then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it's fine to make another sync call when reconnecting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of cause.
Summary
KAG-5895
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]