Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): remove utility classes and css custom properties [KHCP-8877] #1725

Merged
merged 24 commits into from
Sep 14, 2023

Conversation

adamdehaven
Copy link
Member

Summary

Remove utility classes and css custom properties, as well as the @kongponents-css-variables mixin.

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

Remove the generated utility classes and CSS custom properties both from the code, and from exports.

BREAKING CHANGE: Remove exported utility classes and CSS custom properties.
@adamdehaven adamdehaven self-assigned this Sep 13, 2023
@adamdehaven adamdehaven changed the base branch from main to alpha September 13, 2023 15:02
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 1e47a6b
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/65035c3e319220000801b5c8
😎 Deploy Preview https://deploy-preview-1725--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamdehaven adamdehaven marked this pull request as ready for review September 14, 2023 14:30
Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@adamdehaven adamdehaven merged commit 4537d02 into alpha Sep 14, 2023
3 checks passed
@adamdehaven adamdehaven deleted the feat/khcp-8877-remove-utility-exports branch September 14, 2023 20:37
kongponents-bot pushed a commit that referenced this pull request Sep 14, 2023
# [9.0.0-alpha.6](v9.0.0-alpha.5...v9.0.0-alpha.6) (2023-09-14)

### Bug Fixes

* **kcodeblock:** dark theme styles not applying to slotted content ([#1723](#1723)) ([082e4ca](082e4ca))

### Features

* **style:** remove utility classes and css custom properties [KHCP-8877] ([#1725](#1725)) ([4537d02](4537d02))

### BREAKING CHANGES

* **style:** Remove exported utility classes and CSS custom properties.

* fix: trigger ci

* fix: linting

* chore: add comment

* feat: remove css custom properties

* feat: remove css custom properties

* chore: theming

* feat: remove css custom properties

* feat: remove css custom properties

* feat: remove css custom properties

* feat: remove css custom properties

* feat: remove css custom properties

* feat: remove css custom properties

* revert: add back theming styles

* feat: remove css custom properties

* feat: remove css custom properties

* docs: remove theming and removed functionality

* docs: remove unused component

* feat: remove css custom properties

* feat: remove css custom properties

* fix: pagination button

* fix: hover background colors

* chore: remove config
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants