-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(style): remove utility classes and css custom properties [KHCP-8877] #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the generated utility classes and CSS custom properties both from the code, and from exports. BREAKING CHANGE: Remove exported utility classes and CSS custom properties.
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
requested review from
kongponents-bot,
jillztom,
kaiarrowood and
a team
as code owners
September 14, 2023 14:30
portikM
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
kongponents-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
# [9.0.0-alpha.6](v9.0.0-alpha.5...v9.0.0-alpha.6) (2023-09-14) ### Bug Fixes * **kcodeblock:** dark theme styles not applying to slotted content ([#1723](#1723)) ([082e4ca](082e4ca)) ### Features * **style:** remove utility classes and css custom properties [KHCP-8877] ([#1725](#1725)) ([4537d02](4537d02)) ### BREAKING CHANGES * **style:** Remove exported utility classes and CSS custom properties. * fix: trigger ci * fix: linting * chore: add comment * feat: remove css custom properties * feat: remove css custom properties * chore: theming * feat: remove css custom properties * feat: remove css custom properties * feat: remove css custom properties * feat: remove css custom properties * feat: remove css custom properties * feat: remove css custom properties * revert: add back theming styles * feat: remove css custom properties * feat: remove css custom properties * docs: remove theming and removed functionality * docs: remove unused component * feat: remove css custom properties * feat: remove css custom properties * fix: pagination button * fix: hover background colors * chore: remove config
🎉 This PR is included in version 9.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove utility classes and css custom properties, as well as the
@kongponents-css-variables
mixin.PR Checklist