chore(kdatetimepicker): use Timeperiod from public-ui [MA-1995] #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-peteu
requested review from
kongponents-bot,
adamdehaven,
jillztom,
kaiarrowood and
a team
as code owners
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
filipgutica
requested changes
Sep 15, 2023
| @@ -1,20 +1,11 @@ | |||
| import type { AnyElementOf } from '@/types/utils' | |||
|
|
|||
| import type { TimePeriod } from '@kong-ui-public/analytics-utilities' | |||
| export interface TimeRange { | |||
There was a problem hiding this comment.
Can import TimeRange too from analytics-utilities
There was a problem hiding this comment.
No, kongponents cannot have a dependency on another kong package
adamdehaven
requested changes
Sep 15, 2023
| @@ -50,6 +50,7 @@ | |||
| "semantic-release": "semantic-release" | |||
| }, | |||
| "dependencies": { | |||
| "@kong-ui-public/analytics-utilities": "^0.7.2", | |||
There was a problem hiding this comment.
Kongponents cannot have a dependency on this package - this repo is completely isolated from other kong component libraries
adamdehaven
deleted the
chore/ma-1995-datetimepicker-use-analytics-utils-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-1995
PR Checklist