Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinputswitch): fix events race condition #2523

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Nov 21, 2024

Summary

Update order of emits to emit the @update:modelValue event first to fix the issue where events bound to @change event are triggered faster than value bound through v-model is updated, causing a race condition

@portikM portikM self-assigned this Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 9b968e5
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/673f7cad3806260008daf8cb
😎 Deploy Preview https://deploy-preview-2523--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 9b968e5
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/673f7cacf7926a0008d60ae0
😎 Deploy Preview https://deploy-preview-2523--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review November 21, 2024 18:37
@portikM portikM enabled auto-merge (squash) November 21, 2024 18:38
@portikM portikM merged commit 6e3626f into main Nov 21, 2024
11 checks passed
@portikM portikM deleted the fix/kinputswitch-events-race-condition branch November 21, 2024 18:40
kongponents-bot pushed a commit that referenced this pull request Nov 21, 2024
## [9.14.16](v9.14.15...v9.14.16) (2024-11-21)

### Bug Fixes

* **kinputswitch:** fix events race condition ([#2523](#2523)) ([6e3626f](6e3626f))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.14.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants