chore(src): upgrade to openresty 1.21.4.2 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
changed the title
chronolaw
force-pushed
the
chore/upgrade_to_latest_openresty
branch
from
efd0f38
to
0dbfa20
Compare
chronolaw
force-pushed
the
chore/upgrade_to_latest_openresty
branch
3 times, most recently
from
45ecffd
to
29062f9
Compare
remove apple m1 compatible code add `--no-openresty-patches` for build search stream_lua path in config script ngx_stream_lua_request.h typo fix test with 1.21.4.1
chronolaw
force-pushed
the
chore/upgrade_to_latest_openresty
branch
from
29062f9
to
a71cceb
Compare
samugi
reviewed
Sep 7, 2023
| --- error_log | ||
| [lua] ssl_certificate_by_lua:2: ssl cert by lua is running! | ||
| --- error_log eval | ||
| qr/ssl_certificate_by_lua.*ssl cert by lua is running!/ |
There was a problem hiding this comment.
the log was: [lua] ssl_certificate_by_lua(nginx.conf:30):2: ssl cert by lua is running!
There was a problem hiding this comment.
What causes this change? any clue?
There was a problem hiding this comment.
I am trying to figure it out, not sure yet, but it looks like it may have something to do with the upgrade to 1.21.4.2
There was a problem hiding this comment.
@chronolaw I think I found it: openresty/lua-nginx-module#2008, see how the tests changed: https://github.com/openresty/lua-nginx-module/pull/2008/files#diff-9f25aa4f9bc139d6b6d65bf14649c6524911dc99ca7fc92e3337867a969bee1dR120
There was a problem hiding this comment.
Great work, thank you @samugi
chronolaw
changed the title
dndx
approved these changes
Sep 8, 2023
This was referenced Sep 8, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need the related patches of OpenResty 1.21.4.2 to pass the ci tests.
Related PR : Kong/kong#11360
Change logs: