Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed imagePullPolicy and added namespace to local config #25

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ehearneRedHat
Copy link
Contributor

Problem:

  • The imagePullPolicy was preventing the pods from pulling the image from the user's specified repository, causing a ImageNeverPull error.
  • The generated secret from aws-credentials.env was not able to be accessed by pods in the kuadra-system namespace as the secret was generated in the default namespace, causing a CreateContainerConfig error.

Solution:

  • Removing imagePullPolicy from config/local/manager_config_patch.yaml , allowing the pods to pull the image from the user's specified repository.
  • Adding the kuadra-system namespace to config/local/kustomisation.yaml , ensuring the secret is accessible within the kuadra-system namespace for pods which allows the pods to run.

How to reproduce the error (main branch):

# Set up and run the cluster
kind create cluster
make install
IMG=quay.io/<namespace>/kuadra:v1 make docker-build docker-push deploy-local
# Check for imagePullPolicy error
kubectl -n kuadra-system get pods
# Remove imageNeverPull from deployment config
kubectl -n kuadra-system edit deploy kuadra-controller-manager
# Once removed, check for CreateContainerConfig error
kubectl -n kuadra-system get pods
kind delete cluster

How to confirm error is resolved (on deploy-local branch):

# Set up and run the cluster
kind create cluster
make install
IMG=quay.io/<namespace>/kuadra:v1 make docker-build docker-push deploy-local
# Check for imagePullPolicy error
kubectl -n kuadra-system get pods

@ehearneRedHat ehearneRedHat self-assigned this Feb 15, 2024
@ehearneRedHat ehearneRedHat removed the request for review from dlaw4608 February 15, 2024 14:58
@ehearneRedHat ehearneRedHat changed the title Removed imagePullPolicy and added namespace to local config [WIP] Removed imagePullPolicy and added namespace to local config Feb 16, 2024
@ehearneRedHat ehearneRedHat requested a review from KevFan February 16, 2024 13:26
@R-Lawton
Copy link
Contributor

R-Lawton commented Feb 19, 2024

@dlaw4608 When you get a chance do you want to review this to?

@dlaw4608
Copy link

@ehearneRedHat just approved the changes there

@R-Lawton R-Lawton merged commit ea8383d into Kuadrant:main Feb 19, 2024
2 checks passed
@ehearneRedHat ehearneRedHat deleted the deploy-local branch February 20, 2024 08:52
@ehearneRedHat ehearneRedHat changed the title [WIP] Removed imagePullPolicy and added namespace to local config Removed imagePullPolicy and added namespace to local config Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants