Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSPolicy: display healthy cond on get #1074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

maksymvavilov
Copy link
Contributor

@maksymvavilov maksymvavilov commented Dec 9, 2024

when listing policies display healthy condition
image

Signed-off-by: Maskym Vavilov <mvavilov@redhat.com>
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.60%. Comparing base (cc1b41f) to head (748cf9b).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   76.15%   83.60%   +7.45%     
==========================================
  Files         111       81      -30     
  Lines        8986     6699    -2287     
==========================================
- Hits         6843     5601    -1242     
+ Misses       1852      877     -975     
+ Partials      291      221      -70     
Flag Coverage Δ
bare-k8s-integration 15.72% <ø> (+4.84%) ⬆️
controllers-integration 76.08% <ø> (+17.22%) ⬆️
envoygateway-integration 40.84% <ø> (+8.33%) ⬆️
gatewayapi-integration 16.05% <ø> (+2.61%) ⬆️
istio-integration 43.02% <ø> (+8.69%) ⬆️
unit 18.11% <ø> (-7.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.41% <88.57%> (+1.98%) ⬆️
Files with missing lines Coverage Δ
api/v1/dnspolicy_types.go 83.50% <ø> (+15.28%) ⬆️

... and 39 files with indirect coverage changes

@eguzki
Copy link
Contributor

eguzki commented Dec 9, 2024

Just minor comment about the PR title. Make explicit it is about the DNS policy, as it is shown as part of the release notes.

@maksymvavilov maksymvavilov changed the title display healthy cond on get [DNSPolicy] display healthy cond on get Dec 9, 2024
@maksymvavilov maksymvavilov changed the title [DNSPolicy] display healthy cond on get DNSPolicy: display healthy cond on get Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants