Gui: Fix crash in DlgSettingsLightSources #118
Annotations
9 errors and 41 warnings
|
|
src/Mod/Draft/draftguitools/gui_snapper.py#L359
No value for argument 'constrain' in method call (no-value-for-parameter)
|
src/Mod/Draft/draftguitools/gui_snapper.py#L359
No value for argument 'point' in method call (no-value-for-parameter)
|
src/Mod/Draft/draftguitools/gui_snapper.py#L1543
Using variable 'status' before assignment (used-before-assignment)
|
src/Mod/Draft/draftguitools/gui_snapper.py#L1495
Access to member 'toolbar' before its definition line 1497 (access-member-before-definition)
|
|
|
|
src/App/StringHasher.cpp#L319
re-use ==> reuse
|
src/Mod/Draft/draftgeoutils/faces.py#L190
emply ==> employ, empty, imply
|
src/Mod/Draft/draftguitools/gui_snapper.py#L213
fpt ==> ftp
|
src/Mod/Draft/draftguitools/gui_snapper.py#L216
fpt ==> ftp
|
src/Mod/Draft/draftguitools/gui_snapper.py#L218
fpt ==> ftp
|
src/Mod/Draft/draftguitools/gui_snapper.py#L219
fpt ==> ftp
|
src/Mod/PartDesign/PartDesignTests/TestLinearPattern.py#L1
would reformat src/Mod/PartDesign/PartDesignTests/TestLinearPattern.py
|
src/Mod/Draft/draftgeoutils/faces.py#L1
would reformat src/Mod/Draft/draftgeoutils/faces.py
|
src/Mod/PartDesign/PartDesignTests/TestLoft.py#L1
would reformat src/Mod/PartDesign/PartDesignTests/TestLoft.py
|
src/Mod/PartDesign/PartDesignTests/TestPolarPattern.py#L1
would reformat src/Mod/PartDesign/PartDesignTests/TestPolarPattern.py
|
src/Mod/Draft/draftguitools/gui_snapper.py#L1
would reformat src/Mod/Draft/draftguitools/gui_snapper.py
|
src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py#L1
would reformat src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py
|
src/Mod/Draft/draftgeoutils/faces.py#L202
Line too long (103/100) (line-too-long)
|
src/Mod/Draft/draftgeoutils/faces.py#L154
TODO Maybe those edge pair should not be generated in offsetWire() (fixme)
|
src/Mod/Draft/draftgeoutils/faces.py#L171
TODO Need fix further anything if there is a empty [] in faces_list ? (fixme)
|
src/Mod/Draft/draftgeoutils/faces.py#L47
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
|
src/Mod/Draft/draftgeoutils/faces.py#L55
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
|
src/Mod/Draft/draftgeoutils/faces.py#L68
Consider using '{}' instead of a call to 'dict'. (use-dict-literal)
|
src/Mod/Draft/draftgeoutils/faces.py#L78
Consider using [] instead of list() (use-list-literal)
|
src/Mod/Draft/draftgeoutils/faces.py#L158
Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue)
|
src/Mod/Draft/draftgeoutils/faces.py#L184
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
|
src/Mod/Draft/draftgeoutils/faces.py#L112
Too many return statements (7/6) (too-many-return-statements)
|
src/Mod/TechDraw/Gui/TaskProjGroup.cpp#L129
// connect(ui->butReset, SIGNAL(clicked()), this, SLOT(onResetClicked())); <--Consider using Functor-Based Connections
|
src/App/StringHasher.cpp#L29
Found C system header after C++ system header. Should be: StringHasher.h, c system, c++ system, other. [build/include_order] [4]
|
src/App/StringHasher.cpp#L30
Found C system header after C++ system header. Should be: StringHasher.h, c system, c++ system, other. [build/include_order] [4]
|
src/App/StringHasher.cpp#L31
Found C system header after C++ system header. Should be: StringHasher.h, c system, c++ system, other. [build/include_order] [4]
|
src/App/StringHasher.cpp#L32
Found C system header after C++ system header. Should be: StringHasher.h, c system, c++ system, other. [build/include_order] [4]
|
src/App/StringHasher.cpp#L50
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
src/App/StringHasher.cpp#L55
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
src/App/StringHasher.cpp#L57
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
src/App/StringHasher.cpp#L65
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
src/App/StringHasher.cpp#L78
Use int16/int64/etc, rather than the C type long [runtime/int] [4]
|
src/App/StringHasher.cpp#L81
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
This job succeeded
Loading