fix if show btn approve. dont show options

f fix
KyberNetwork · Oct 11, 2023 · 308a42c · 308a42c
1 parent 1ac0790
commit 308a42c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/components/swapv2/LimitOrder/ActionButtonLimitOrder.tsx b/src/components/swapv2/LimitOrder/ActionButtonLimitOrder.tsx
@@ -56,7 +56,8 @@ export default function ActionButtonLimitOrder({
 }) {
   const disableBtnApproved =
     approval === ApprovalState.PENDING ||
-    ((approval !== ApprovalState.NOT_APPROVED || approvalSubmitted || !!hasInputError) && enoughAllowance)
+    !!hasInputError ||
+    ((approval !== ApprovalState.NOT_APPROVED || approvalSubmitted) && enoughAllowance)
 
   const disableBtnReview =
     checkingAllowance ||

diff --git a/src/components/swapv2/LimitOrder/EditOrderModal.tsx b/src/components/swapv2/LimitOrder/EditOrderModal.tsx
@@ -113,11 +113,13 @@ export default function EditOrderModal({
   const isWaiting = cancelStatus === CancelStatus.WAITING
   const showReview = isReviewOrder && isWaiting
 
+  // todo
   const ref = useRef<LimitOrderFormHandle>(null)
   const renderCancelButtons = () => {
     const hasChangeInfo = step === Steps.EDIT_ORDER ? ref.current?.hasChangedOrderInfo?.() : true
     const disabledGasLessCancel = !hasChangeInfo || !supportGasLessCancel || flowState.attemptingTxn
     const disabledHardCancel = !hasChangeInfo || flowState.attemptingTxn
+    if (!ref.current?.isShowApprove?.()) return null
     return (
       <>
         {isReviewOrder && (

diff --git a/src/components/swapv2/LimitOrder/LimitOrderForm.tsx b/src/components/swapv2/LimitOrder/LimitOrderForm.tsx
@@ -111,6 +111,7 @@ const ExpiredInput = styled(InputWrapper)`
 `
 export type LimitOrderFormHandle = {
   hasChangedOrderInfo: () => boolean
+  isShowApprove: () => boolean
 }
 const LimitOrderForm = forwardRef<LimitOrderFormHandle, Props>(function LimitOrderForm(
   {
@@ -583,7 +584,6 @@ const LimitOrderForm = forwardRef<LimitOrderFormHandle, Props>(function LimitOrd
     !checkingAllowance &&
     !showWrap &&
     !isNotFillAllInput &&
-    !hasInputError &&
     (approval === ApprovalState.NOT_APPROVED ||
       approval === ApprovalState.PENDING ||
       !enoughAllowance ||
@@ -601,11 +601,15 @@ const LimitOrderForm = forwardRef<LimitOrderFormHandle, Props>(function LimitOrd
     hasChangedOrderInfo() {
       return (
         isEdit &&
+        !hasInputError &&
         (defaultInputAmount !== inputAmount ||
           defaultRate?.rate !== rateInfo.rate ||
           defaultExpire?.getTime() !== expiredAt)
       )
     },
+    isShowApprove() {
+      return isEdit && !showApproveFlow
+    },
   }))
 
   const renderConfirmModal = (showConfirmContent = false) => (