Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: current list lag #2342

Merged
merged 2 commits into from
Oct 28, 2023
Merged

fix: current list lag #2342

merged 2 commits into from
Oct 28, 2023

Conversation

nguyenhoaidanh
Copy link
Contributor

@nguyenhoaidanh nguyenhoaidanh commented Oct 28, 2023

  • this pr will fix currency list lag, especially in output currency in crosschain page.
  • root cause: too many unnecessary calculations
  • solution:
    -- bring out calculations from TokenRow to the CurrencyList
    -- remove check ContentHash calc in token logo, don't need.
    -- use useActiveWeb3React() in TokenRow also make UI lag
  • result:
    -- before: click output currency of croschain page => can not show currency modal. It happened when we have this line const provider = useWrappedProvider() in useWeb3React hooks.
    -- after: click output currency of croschain page => can show currency modal
image
image

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-2342.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nguyenhoaidanh nguyenhoaidanh marked this pull request as ready for review October 28, 2023 08:01
@nguyenhoaidanh nguyenhoaidanh merged commit ad2b4f5 into main Oct 28, 2023
8 checks passed
@nguyenhoaidanh nguyenhoaidanh deleted the fix-currency-lag branch October 28, 2023 11:11
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-2342.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants