Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call import token if token not found #2387

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

neikop
Copy link
Contributor

@neikop neikop commented Nov 16, 2023

https://team-kyber.atlassian.net/browse/KEP-1891

We didn't return token info when fetching a token that is not indexed.
-> Improve: Automatically call "import token" if query token not found.

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-2387.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

src/hooks/Tokens.ts Outdated Show resolved Hide resolved
src/hooks/Tokens.ts Outdated Show resolved Hide resolved
@nguyenhoaidanh
Copy link
Contributor

nguyenhoaidanh commented Nov 16, 2023

nice idea, make sure QA tested it.

@neikop neikop force-pushed the update/Call-import-token-if-token-not-found branch from bace627 to 6849d0c Compare November 20, 2023 05:15
@neikop neikop requested a review from viet-nv November 20, 2023 05:25
nguyenhoaidanh
nguyenhoaidanh previously approved these changes Nov 22, 2023
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

ADPR instace has been updated!

Information

@neikop neikop merged commit 13318cf into main Nov 23, 2023
7 checks passed
@neikop neikop deleted the update/Call-import-token-if-token-not-found branch November 23, 2023 04:34
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Clean up resources have been completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants