Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash kyberAI when wrong chain #2407

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: crash kyberAI when wrong chain #2407

merged 1 commit into from
Nov 29, 2023

Conversation

nguyenhoaidanh
Copy link
Contributor

  • root cause: re-render too much => make rtk query inside that component call too much => memory leak
  • solution: memo it.
  • reproduce on kyberswap.com:
    --change chain in your wallet to strange chainId (not support chain)
    --visit kyberAI page
    --wait a bit, crash

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

ADPR instance has been created!

Information

@nguyenhoaidanh nguyenhoaidanh merged commit 80c1a75 into main Nov 29, 2023
8 checks passed
@nguyenhoaidanh nguyenhoaidanh deleted the fix-crash branch November 29, 2023 06:38
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Clean up resources have been completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neikop neikop neikop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nguyenhoaidanh @kyber-ci-bot @neikop