Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename todos #2506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/TradeRouting/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const RouteRow = ({ route, chainId, backgroundColor }: RouteRowProps) => {
const dex = getDexInfoByPool(pool, allDexes)
const poolId = pool.id.split('-')?.[0]
const link = (i => {
// TODO: Dungz remove condition
// TODO: viet-nv remove condition
return isAddress(chainId, poolId) && !['1inch', 'paraswap', '0x'].includes(pool.exchange) ? (
<StyledExchange
key={`${i}-${pool.id}`}
Expand Down
2 changes: 1 addition & 1 deletion src/constants/permit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const PERMITTABLE_TOKENS: {
}
} = {
[ChainId.MAINNET]: {
// '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48': { type: PermitType.SALT, version: '1' }, // USDC // TODO: Diep will check these tokens later
// '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48': { type: PermitType.SALT, version: '1' }, // USDC // TODO: viet-nv will check these tokens later
// '0x6B175474E89094C44Da98b954EedeAC495271d0F': { type: PermitType.SALT, version: '1' }, // DAI
'0xba100000625a3754423978a60c9317c58a424e3D': { type: PermitType.AMOUNT, version: '1' }, // BAL
'0xC18360217D8F7Ab5e7c516566761Ea12Ce7F9D72': { type: PermitType.AMOUNT, version: '1' }, // ENS
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useChainsConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export enum ChainState {
export type ChainStateMap = { [chain in ChainId]: ChainState }

const cacheInfo: { [chain: string]: NetworkInfo } = {}
// todo danh, when chain setting from admin ready, update all place use this
// todo viet-nv, when chain setting from admin ready, update all place use this
export const NETWORKS_INFO = new Proxy(NETWORKS_INFO_HARDCODE, {
get(target, p) {
const prop = p as any as ChainId
Expand Down
2 changes: 1 addition & 1 deletion src/services/coingecko.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const coingeckoApi = createApi({
}),
})

// todo danh (not for now) move basic chart api to this file
// todo viet-nv (now) move basic chart api to this file
export const { useGetMarketTokenInfoQuery, useGetLiquidityMarketsQuery, useGetSecurityTokenInfoQuery } = coingeckoApi

export default coingeckoApi
2 changes: 1 addition & 1 deletion src/state/farms/classic/knUpdater.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const KNUpdater = ({ isInterval = true }: { isInterval?: boolean }) => {
// : farmPool.version === 2
// ? FairLaunchVersion.V2
// : FairLaunchVersion.V3
// todo namgold: subgraph issue, revert this later
// todo viet-nv: subgraph issue, revert this later
const version: FairLaunchVersion =
Number(farmPool.start) < 1_000_000_000 ? FairLaunchVersion.V1 : FairLaunchVersion.V2
const rewardTokens: Token[] = farmPool.rewardTokens.map(({ id, decimals, symbol, name }) =>
Expand Down
2 changes: 1 addition & 1 deletion src/state/pools/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ async function getBulkPoolDataWithPagination(
current.data.pools.map(async (pool: any) => {
let data = { ...pool }
const oneDayHistory = oneDayData?.[pool.id]
// TODO nguyenhuudungz: If number of pools > 1000 then uncomment this.
// TODO viet-nv: If number of pools > 1000 then uncomment this.
// if (!oneDayHistory) {
// const newData = await apolloClient.query({
// query: POOL_DATA(pool.id, b1),
Expand Down
Loading