Merge branch 'dependabot/github_actions/actions/download-artifact-4' …

…into dependabot/github_actions/actions/upload-artifact-4

I think both artifact interaction mechanisms need to be updated at the
same time in order for them to properly interact with each other so I'm
merging these changes

.github/workflows/generate_pr_gold.yml

@@ -45,7 +45,7 @@ jobs:
       matrix: ${{fromJson(needs.compile-ldmx-sw.outputs.job_matrix)}}
     steps:
     - name: Download ldmx-sw Package
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ldmx-sw-build-${{ github.sha }}
 
@@ -81,7 +81,7 @@ jobs:
 
     - name: Download All the Gold
       id: download
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         path: '../'
 

.github/workflows/new_pre_release.yml

@@ -55,7 +55,7 @@ jobs:
       matrix: ${{fromJson(needs.compile-ldmx-sw.outputs.job_matrix)}}
     steps:
     - name: Download ldmx-sw Package
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ldmx-sw-build-${{ github.sha }}
 
@@ -82,7 +82,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Download Generated Histograms
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         path: '.'
 

.github/workflows/pr_validation.yml

@@ -53,7 +53,7 @@ jobs:
       fail-fast: false
     steps:
     - name: Download ldmx-sw Package
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ldmx-sw-build-${{ github.sha }}