Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ECAL lin-reg #1420

Open
tvami opened this issue Aug 29, 2024 · 0 comments · May be fixed by #1497
Open

Optimize ECAL lin-reg #1420

tvami opened this issue Aug 29, 2024 · 0 comments · May be fixed by #1497
Assignees
Labels

Comments

@tvami
Copy link
Member

tvami commented Aug 29, 2024

Is your feature request related to a problem? Please describe.

This is a follow-up to #1407
There are several things to make the lin-reg better. List below.

Describe the solution you'd like

  1. Implement that we really are selecting hits from the closest hits
    // int hitsInRegion[50];

    and then
    if (trackingHitList.size() < 3) break;

    it should prob take the hits from trackingHitList[hitsInRegion[jHit]] and also trackingHitList[hitsInRegion[kHit]] and propagate this below in the code too.
  2. That opens up immediately that 50 in int hitsInRegion[50]; might be not realistic
  3. And then the distance in
    if (dstToHit <= 2 * cellWidth) {
    was not optimized at all.

Besides the physics changes discussed above we could also consider to move away from the ROOT approach and use Eigen instead.

Describe alternatives you've considered

Keep it as it is, currently it's not really used, but I think it has potential.

@tvami tvami added the ecal label Aug 29, 2024
@tvami tvami self-assigned this Sep 2, 2024
@tvami tvami linked a pull request Nov 20, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant