Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ECAL lin-reg MIP tracking #1497

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

tvami
Copy link
Member

@tvami tvami commented Nov 20, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1420

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

This is a work together with @kawaterrysit
We optimized kaons vs signal, I'll attach the plot when we fully converge, but the 23 mm seems already pretty good. Edit: the best option actually seems to be 35 mm.

With the original setting we really were just looking in the front ECAL since the 9 mm setting would not reach the next layer in the back ECAL. So we expect much more tracks to be built like this.

@tvami
Copy link
Member Author

tvami commented Nov 20, 2024

With the original setting we really were just looking in the front ECAL since the 9 mm setting would not reach the next layer in the back ECAL. So we expect much more tracks to be built like this.

And indeed we see much more tracks.
For signal
Screenshot 2024-11-19 at 20 14 08

For the kaons
Screenshot 2024-11-19 at 20 14 31

For ecal PN
Screenshot 2024-11-19 at 20 14 44

The plot that shows why 23 is pretty good already will come tomorrow

@tvami tvami marked this pull request as ready for review November 21, 2024 20:59
@tvami
Copy link
Member Author

tvami commented Nov 21, 2024

Here is the presentation that shows the effect of the different values
Optimizing Linear Regression MIP Tracking.pdf

@tvami
Copy link
Member Author

tvami commented Nov 22, 2024

signal
Screenshot 2024-11-22 at 12 27 35

kaons
Screenshot 2024-11-22 at 12 23 39

ecalPN
Screenshot 2024-11-22 at 12 24 04

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a lot of tracks, but I also suppose we have low requirements and an entire shower to analyze.

One feature I would like to be considered is to "extend" tracks. How many of these tracks are just several 3-hit segments of something we would consider a single track? This may be too big of an ask and is venturing close to doing full-scale tracking which we could probably just use ACTS for at some point.

@tvami
Copy link
Member Author

tvami commented Nov 22, 2024

Yeah calling these "tracks" is actually an overstatement. All of these are 3-hit segments, so if you have a long track that makes 15 hits, that's going to lead to 5 "track" on this plot. And that's one reason for the inflation. The other is that in the past with the old radius we technically didnt use the back ECAL at all, so now adding all those makes more "tracks".

I think you have a good point, but I dont see how to do it with the current code. I kinda agree that we should just move away from the lin-reg approach for the further future. We actually played with ACTS w/ B=0 field for the reduced tracker that didnt really work out well, but the algo mentioned in #1491 could be explored for ECAL usage too

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, the ECal situation is weird. We don't need a good track fit, we just want to be able to algorithmically recognize tracks out of a sea of hits.

I think this is good as is, I'm glad to hear there are two reasons for such a large increase in the number of "tracks". Since both signal and background overflow our histograms, maybe we need to extend the axis in DQM as well? Might need to be reserved for future, I have no idea how that will interact with our CI testing.

I also am very invested in using good vocabulary, so maybe the histograms and some other important locations could use a different word that track? tracklets? track segments?

@tvami
Copy link
Member Author

tvami commented Nov 23, 2024

I propose to extend and rename in the PR that addresses #1486

I do actually plan to tackle that soon too, although next week is tricky with Thanksgiving. But it should prob be done before the next ldmx-sw is cut.

Here is a normalized plot with an overflow bin btw:
Screenshot 2024-11-22 at 16 46 58

(this is after trigger and fiducial, seems to change the ecalPN quite a lot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize ECAL lin-reg
2 participants