Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trigger threshold defaults #1468

Closed
tvami opened this issue Sep 19, 2024 · 3 comments · Fixed by #1469
Closed

Change trigger threshold defaults #1468

tvami opened this issue Sep 19, 2024 · 3 comments · Fixed by #1469
Assignees

Comments

@tvami
Copy link
Member

tvami commented Sep 19, 2024

Is your feature request related to a problem? Please describe.

self.thresholds = [ self.beamEnergy/4000.*1500.0, self.beamEnergy/4000.*1000. + self.beamEnergy, self.beamEnergy/4000.*500. + 2*self.beamEnergy, self.beamEnergy/4000.*100. + 3*self.beamEnergy ]

 self.thresholds = [ self.beamEnergy/4000.*1500.0, self.beamEnergy/4000.*1000. + self.beamEnergy, self.beamEnergy/4000.*500. + 2*self.beamEnergy, self.beamEnergy/4000.*100. + 3*self.beamEnergy ]

leads to 3000, 10000, 17000, 24200, while
@EBerzin 's studies lead to different numbers
https://indico.fnal.gov/event/64932/#25-multi-electron-trigger-thre
(although I think Elizabeth was looking at the 34 layers of ECAL, which is not the same as the one we have )

Describe the solution you'd like

Agree on the final numbers and have them in ldmx-sw.
I should add that I strongly believe we should keep the 1e threshold at 3000, so we dont need to redo all the 1e studies (trig skim, BDT, etc), even if it's not fully optimal.

@EBerzin
Copy link
Contributor

EBerzin commented Sep 19, 2024

I've attached the full set of optimized trigger thresholds (20 and 34 layers for mu = 1 and mu = 2). For 20 ECAL layers, the thresholds are 3.01, 10.79, 18.54, 26.25 GeV. So keeping the 1e threshold at 3000 is consistent with this.

LDMX_TS_Trigger_Thresholds.pdf

@tvami
Copy link
Member Author

tvami commented Sep 19, 2024

Awesome, thanks a lot @EBerzin !
So then next is to figure out how to implement this so it works for both 4 GeV and 8 GeV. Maybe just add an if on the beamEnergy hand have two different lines for self.thresholds as opposed to having it as a function of the energy? Elizabeth do you wanna go ahead with the PR, or should I?

@EBerzin
Copy link
Contributor

EBerzin commented Sep 20, 2024

I can take of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants