-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default trigger thresholds #1469
Change default trigger thresholds #1469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have one small comment:
Co-authored-by: Tamas Vami <tamas.almos.vami@cern.ch>
Thanks @EBerzin ! |
Actually one more thing: can you please edit the PR description too to reflect you also changed the 4 GeV settings (with a link to the talk from Megan) |
I'd like to trigger the full test, for that I'll move this to "draft" and back to "ready" |
there are a few places where the trigger decision differs but I guess either a) there are no trigger pass/fail plots in the DQM b) the KS test still judges the distributions to be "from the same underlying distribution" examples from the log diff:
|
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1468. I've updated the 8 GeV default thresholds to reflect the optimized values calculated for a mu=1 Poisson beam profile, and 20 ECal layers. The 1e threshold was kept at 3 GeV, which also happens to be consistent with the optimized value (3.01 GeV).
Thresholds for 4 GeV were also updated to reflect thresholds calculated by Megan, as reported here: https://indico.fnal.gov/event/51366/contributions/225984/attachments/148282/190432/MeganLoh_multielectronTriggering.pdf
The 1e- threshold at 4 GeV was kept at 1.5 GeV.
Check List