-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use logs as part of the validation #1198
use logs as part of the validation #1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Tom!
the timestamps printed out by some processors prevents a full text diff from being successful so we just write the diff to the output and continue no matter what
Just noticed that the logs for, was it inclusive and maybe pileup/hcal/more? spit out a configuration error where some set parameter is wrongly typed as float or int (don’t remember which way). A good time to fix this? |
Ive been wondering what that warning comes from, if it is a parameter that is wrong wouldn't the whole thing halt? So I would have thought that it comes from somewhere else |
I first noticed that warning/error when updating to the newer compiler. I am unsure where it is originating - if its in the python or C++ side of configuration. I agree with Einar, that it would halt if the parameter was wrong, but we could easily be misinterpreting some of the Python C-API functions that we are using. For now, I think it is best to leave it since I do not know what kind of rabbit-hole tracing it will lead to. If I have time, I can open an issue with a first look at it. |
Since `set -e` is at the top of the script, we need to explicitly avoid any non-zero return code by using `|| true`.
I made #1199 as the possible source for the |
Alright, I generated the gold logs with an intentionally slightly old commit of ldmx-sw which produced slightly different logs. This means we get the following report from GitHub. I don't think this is enough since the checks are still labeled as "passing" here, so I am going to move the character-count checking from warning to error and put it in a different job step. |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1192 by updating the CI scripts to store and compare the terminal output when running
fire
.Check List
I attached any sub-module related changes to this PR.