-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move msgs in EcalProcessFilter to logging system #1277
Conversation
I also expect the log diff tests to fail with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great, thanks for following up on this @tvami!
indeed the log diff is (except a few time stamps from configuration printouts) an ecal printout for each event. @tomeichlersmith @EinarElen thoughts on this, should the CI use logs at debug level to catch any differences? |
Seems reasonable to me! |
I agree with this! It should be for all the tests, so beyond this PR, maybe we should just made its own issue for this? |
For reference: #1280 |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1250
Check List
I successfully compiled ldmx-sw with my developments
I ran my developments and the following shows that they are successful.
Running
Now the
are not printed out by default.
N/A