Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions on v0.2.0 #1290

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conditions on v0.2.0 #1290

merged 1 commit into from
Apr 30, 2024

Conversation

tomeichlersmith
Copy link
Member

@tomeichlersmith tomeichlersmith commented Apr 29, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This is helpful preparation for #1275 by closing the last PR in Conditions and then making the last release (hopefully if this doesn't break anything which it shouldn't).

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.
  • I attached any sub-module related changes to this PR.

Related Sub-Module PRs

@tomeichlersmith tomeichlersmith marked this pull request as ready for review April 29, 2024 23:55
@tomeichlersmith
Copy link
Member Author

The failing plots are the same as from #1245

@tomeichlersmith tomeichlersmith merged commit 6729a82 into trunk Apr 30, 2024
9 of 13 checks passed
@tomeichlersmith tomeichlersmith deleted the bump-Conditions branch April 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant