Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce variable for total events with no tries limit #1322

Merged
merged 1 commit into from
May 7, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented May 6, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1299

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

I ran the pn code and set

p.run = 2
p.maxEvents = 1
  • In default I get
Started 23 events to produce 1 events.
  • then
p.maxEvents = 1
p.maxTriesPerEvent = 10

leads to

Started 10 events to produce 1 events.
  • then
p.maxEvents = 1
p.maxTriesPerEvent = 10
p.totalEvents = 1

leads again to

[ Process ] 2 : The totalEvents was set, so maxEvents and maxTriesPerEvent will be ignored!
Started 23 events to produce 1 events.

as expected

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I would just ask for the totalEvents config option to be added to the python config class documentation and include reference to it in the max* descriptions since they will be ignored if it is used.

maxEvents : int
Maximum number events to process
maxTriesPerEvent : int
Maximum number of attempts to make in a row before giving up on an event
Only used in Production Mode (no input files)

Framework/src/Framework/Process.cxx Outdated Show resolved Hide resolved
@tvami tvami force-pushed the iss1299-totalEvents branch from b8197c4 to 661aca3 Compare May 7, 2024 00:03
@tvami tvami requested a review from tomeichlersmith May 7, 2024 00:04
@tvami
Copy link
Member Author

tvami commented May 7, 2024

Thanks Tom, I've changed those points

@tvami tvami merged commit 69f01ee into trunk May 7, 2024
1 check passed
@tvami tvami deleted the iss1299-totalEvents branch May 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an ability to ask for N total events to process in addition to the maximum number of events
4 participants