Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kaon validation + fix tracking seeder settings in ecal validation #1421

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Aug 30, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

@tvami
Copy link
Member Author

tvami commented Aug 30, 2024

@tomeichlersmith I think now there is enough change to cut a new patch + golds after this? Maybe with the denv PR in too (feels like it's close, if not that's ok)?

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some detail changes since these CI configs tend to last a long time and become references.

.github/validation_samples/kaon_enhanced/config.py Outdated Show resolved Hide resolved
.github/validation_samples/kaon_enhanced/config.py Outdated Show resolved Hide resolved
.github/validation_samples/kaon_enhanced/config.py Outdated Show resolved Hide resolved
@tomeichlersmith
Copy link
Member

Yea, I think I can get the just+denv PR ready in a few days. I mainly just want to finish the updates to the documentation website and do some final testing on denv before making a v1 release.

@tvami tvami force-pushed the iss1418-add-kaon-validation branch from 834f938 to 181267b Compare August 30, 2024 15:36
@tvami tvami force-pushed the iss1418-add-kaon-validation branch from 181267b to bf64ef9 Compare August 30, 2024 15:52
@tvami tvami merged commit d140fd3 into trunk Aug 30, 2024
2 checks passed
@tvami tvami deleted the iss1418-add-kaon-validation branch August 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kaon to the CI validation suite
4 participants