-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ECal cellxy.txt and use EcalGeometry instead #1425
Conversation
111923a
to
535af36
Compare
@tomeichlersmith I think we should cut gold and then have this PR in, like that it nicely separates from other developments (like the lin-reg changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent update and one that a student I'm working with also has a use for!
My only comment is about reducing duplication.
175575e
to
542e85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
The last thing is just to update the documentation of getID
to include the fallible
parameter. And maybe an example about how to use it, e.g.
(doxycomments can contain codeblocks just like markdown).
auto id = geometry.getID(x, y, ilayer, true);
if (id.null()) {
// position (x,y) is not contained within a cell in layer ilayer
}
542e85a
to
2645419
Compare
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1413
The code certainly got much simpler like this, no weird stepping in the
mapsx
/mapsy
anymore.Check List
As a test I fixed the X location to -9999, or to -270 --> indeed it shows that it's not fiducial.
Otherwise ran the new kaon config, the fiducial case looked ok too.
I expect the bigger effects to show up in signal, especially with the 1 GeV case.