Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more features to ECAL DQM & validation module #1440

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 6, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1398

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

All the new histos in the histo.root file created by the CI config look as they should tho!
The validation module works too, tho I had to make the changes as in #1441

denv python3 -m Validation compareDir/ --systems ecal.digi_verify
denv python3 -m Validation compareDir/  --systems ecal.mip_tracking
denv python3 -m Validation compareDir/  --systems ecal.veto_results

@tvami tvami marked this pull request as ready for review September 6, 2024 14:45
@tvami tvami requested review from danyi211 and tomeichlersmith and removed request for danyi211 September 6, 2024 14:49
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :) thanks for keeping things separate and organized, I like small and well-defined processors.

@tvami
Copy link
Member Author

tvami commented Sep 6, 2024

Thanks for the quick approval guys! I'll delay merging this bc it changes the gold, after #1442 and #1406 are resolved

@tvami tvami force-pushed the iss1398-impr-ecal-dqm branch from 72f4726 to d8d359a Compare September 6, 2024 19:29
@tvami tvami merged commit f942699 into trunk Sep 6, 2024
2 checks passed
@tvami tvami deleted the iss1398-impr-ecal-dqm branch September 6, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more features to ECAL DQM & validation module
3 participants