Misc code improvements: override, destructor, small mistakes #1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This is part of #1176
Specifically running
Check List
Errors/warnings are gone, except for Static analysis meta-issue #1176 (comment)
I moved every instances of
final override
tooverride
now in bb2eef4 based on the guidelines in https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override