Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc code improvements: override, destructor, small mistakes #1447

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 6, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This is part of #1176
Specifically running

just configure  -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang
just build 

Check List

I moved every instances of final override to override now in bb2eef4 based on the guidelines in https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override

Biasing/include/Biasing/TargetDarkBremFilter.h Outdated Show resolved Hide resolved
@EinarElen
Copy link
Contributor

@tvami
Copy link
Member Author

tvami commented Sep 8, 2024

I moved every instances of final override to override now in bb2eef4

@tvami tvami merged commit 56ac716 into trunk Sep 9, 2024
4 of 10 checks passed
@tvami tvami deleted the iss1176-part1 branch September 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants