-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tracking timing precision, fixes to DQM histo names #1448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, the reason I'm holding approval is just because this changes the gold in two ways (in the logs and by adding the chi2/ndf histogram to the list of histograms that the current validation comparison tool can handle). Is there anything else we want to merge before changing the gold?
My take is that we can merge this, but not yet make a new patch release / gold. The changes introduced in this PR are exactly taking care of the things that don't work in the comparison, i.e. every validation now fails with (1) not finding the /ndf plots and (2) due to the instability of the tracking timing measurement. By merging this every validation will continuingly fail at these two points, but for a different reason. i.e. it's like a status que until we cut new gold (for which that I agree that it's too early) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am convinced by your reasoning 👍
I pushed one more cosmetics change in 4af0355 |
@bloodyyugo are you ok with me changing the tracking DQM histo names? I think this is the only way to have the CI script understand that it's not a directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look fine to me.
Yeah, I was going to change this but you got to it first. Thanks
|
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1402
Check List