Part 2 of static analysis code improvements

[tvami]

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Part 2 of #1176

Check List

• I successfully compiled ldmx-sw with my developments
• I ran my developments and the following shows that they are successful.

Running

just configure -DADDITIONAL_WARNINGS=ON -DENABLE_LTO=ON  -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang
just build 

the warnings/errors are gone after this PR.

[tvami]

There are plenty variables that are in the code and are not used (thus the compiler will complain). The approach I took was to comment them out for now and put a flag FIXME and bring them to subsystem experts to see if they are ok to get removed, so I'm tagging Tom, Einar, Lene Kristian and Matt directly at point where I'd need confirmation. I think many of them are there for future developement, in those cases, we can keep them commented until they are needed.

[tvami]

Also no changes observed in the CI tests:
https://github.com/LDMX-Software/ldmx-sw/actions/runs/10801316844

[bloodyyugo]

I went through all the issues assign to me ... most are ok to delete, but I want to keep some. It wouldn't let me commit in-line.

[tvami]

I went through all the issues assign to me ... most are ok to delete, but I want to keep some. It wouldn't let me commit in-line.

Thanks Matt, I'll do one commit to address them all!

[tvami]

@bloodyyugo I pushed it now, please approve if it looks good

[bloodyyugo]

Good to go.

[tvami]

I'm going to merge this now, and address the TS related (only 4 files, the rest are all good) questions in a new PR.
@bryngemark please do comment on this PR if I can delete those lines of code that I asked you about, if yes, I'll delete them in my next (and hopefully last) PR

[bryngemark]

sorry to be late to the party! but maybe only one deletion to make @tvami :)

[tvami]

No worries, still in time for part 3 so we are good! Thanks