Add condition for not being on trunk when pushing in format CI #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvami
force-pushed
the
iss1457-auto-commit-clang-format
branch
from
23a842e to
ae7892b
Compare
tvami
changed the title
tomeichlersmith
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Going to use my unlimited power ™️ to merge this since we can only really test this on trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Format check fails on trunk
https://github.com/LDMX-Software/ldmx-sw/actions/runs/10923712245/job/30321004467
because there is nothing to commit (which I tested already, and works) BUT now we are also not on a PR branch but on
trunk(this I couldn't test until the prev PR was merged).Check List
Post-merge comment: indeed push was skipped on trunk https://github.com/LDMX-Software/ldmx-sw/actions/runs/10924826800/job/30324837501