Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ldmx-reduced-v2 #1489

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Introduce ldmx-reduced-v2 #1489

merged 1 commit into from
Oct 17, 2024

Conversation

SanjitMasanam
Copy link
Contributor

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolved #1483

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

Simulating 3 GeV electrons showering in the ECal, we see a significant improvement in the shower containment of the ECal between v1 and v2.

image

@SanjitMasanam SanjitMasanam linked an issue Oct 16, 2024 that may be closed by this pull request
@SanjitMasanam SanjitMasanam changed the title Iss1483 reduced v2 Iss1483 Reduced v2 Oct 16, 2024
Copy link
Member

@tvami tvami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks Sanjit

@tvami tvami changed the title Iss1483 Reduced v2 Introduce ldmx-reduced-v2 Oct 16, 2024
@tvami tvami requested a review from tomeichlersmith October 17, 2024 14:25
@SanjitMasanam SanjitMasanam self-assigned this Oct 17, 2024
@SanjitMasanam SanjitMasanam merged commit 96f6980 into trunk Oct 17, 2024
3 checks passed
@SanjitMasanam SanjitMasanam deleted the iss1483-reduced-v2 branch October 17, 2024 18:35
@github-actions github-actions bot restored the iss1483-reduced-v2 branch October 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduced v2 Geometry Implementation
3 participants