use denv v1.1.0's quiet no-overwrite init flags #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this simplifies just init for newer denv and avoids a confusing error message that is usually just passed by
|
I tried to test this, but I get on POD when I do |
|
Doing it on SLAC, where I had older so maybe we should add another msg to make sure the user uses new enough |
|
Apologies! I should have opened this as draft. I did not do any testing myself on anywhere outside my laptop. I'll mark as ready-for-review when I feel like it is ready. |
typo was preventing getting the minor version causing that check to always fail. also putting quotes around all the environment variables now as well.
new shellcheck recipe is focused on shellcheck'ing the recipes within the justfile itself. As they get more complicated, it is helpful to make sure that we maintain good shell style. Don't leave shellchecks early on an error so that we can make sure that the temporary files that are spawned are removed.
allows possibility of white-space characters in filepaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies
just initfor newerdenvusers and avoids a confusing error message that is ignored because we immediately follow up a missing workspace with creating the workspace.