-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use recoil tracking's extrapolated position in EcalVeto #1495
base: trunk
Are you sure you want to change the base?
Conversation
@therwig I thought I'd bring your attention to the validation plots I posted here too. Quite a lot more tracks in the ecal PN as well |
I was talking with @danyi211 about this, she pointed out that if the recoil track is on the left, that means that the photon projection is on the right. But if you mismeasure by the tracking that the recoil track is on the right, then the photon projection will be on left -- but that's where the real electron shower is!! so you'll find MIP tracks bc there are MIP tracks from the electron. |
Thanks for sharing these - interesting. The straight tracks are quite striking :) |
auto trk_ts = track.getTrackState(ts_type); | ||
// Continue if there's no value | ||
if (!trk_ts.has_value()) continue; | ||
ldmx::Track::TrackState &TargetState = trk_ts.value(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should actually be
ldmx::Track::TrackState &TargetState = trk_ts.value(); | |
ldmx::Track::TrackState &EcalTrackState = trk_ts.value(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please have the variable be snake_case
instead of CamelCase
so that it is easy to visually distinguish from classes (CamelCase
) and functions (someWeirdJavaThing
).
auto trk_ts = track.getTrackState(ts_type); | ||
// Continue if there's no value | ||
if (!trk_ts.has_value()) continue; | ||
ldmx::Track::TrackState &TargetState = trk_ts.value(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please have the variable be snake_case
instead of CamelCase
so that it is easy to visually distinguish from classes (CamelCase
) and functions (someWeirdJavaThing
).
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1494
Introduced
recoil_from_tracking_
boolean, which if switched on will propagate the recoil track to the ECAL face and use that to make the projections.For now I kept the default boolean False, and switched it on for the ecalPN sample, where we run the tracking anyway.
Check List
Unfortunately the ecalPN sample we have did not save the tracking simhits so I cannot rerun tracking on with.
I ran on the kaon samples tho which did keep the hits. I'll show the results at the SWAN meeting on Monday.
Much of this work was done by @JYoo001 who also made plots quantifying the distance between the projected and real positions in the ECAL (this we showed at a tracking meeting)