Fix: cross monitor animation #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes cross-monitor drag move by extending cancelling system. Now each cancel call have its own idx. And only latest cancel will continue animation. Others will be dropped.
Global variable removed due to previous fix commit
|
There is some strange error when you move the window with the mouse. recordedVideo.mp4 |
Fixed in last commit |
LGUG2Z
pushed a commit
that referenced
this pull request
Aug 24, 2024
This commit is a squashed combination of the following commits from #920 by @thearturca. Thanks to both @thearturca for @amnweb for their work in fixing and thoroughly testing these changes respectively. 9350792 fix(animation): added pending cancel count to track `is_cancelled` state 84ad947 refactor(animation): remove cancel idx decreasing 804b038 refactor(animation): remove `ANIMATION_TEMPORARILY_DISABLED` global vars f257873 fix(animation): extend cancelling system to support multiple cancel call dfd6e98 refactor(window): reuse window rect in `animate_position` method
|
Merged with an interactive rebase here: 9260b68 Thank you @thearturca! |
|
I've just tested the cross-monitor animations from the latest in master branch (9260b68) and it seems to hide the window borders (Komorebi implementation) and also the stackbars. This happens only when moving windows across monitors, and not when just moving windows on one monitor. output.mp4 |
thearturca
force-pushed
the
fix/cross-monitor-animation
branch
from
3284617
to
9350792
Compare
…cel_count` field Before it was checking `cancel_idx_counter` which is `id` counter. It never gonna equals `0` and doesn't represent all animations that running for that window. So it doesn't delete entry from hashmap. That leads to bug when border and stackbar doesn't get notified after animation ends.
Found a bug. Now this is fixed for this PR |
LGUG2Z
pushed a commit
that referenced
this pull request
Aug 25, 2024
This commit is a squashed combination of the following commits from #920 by @thearturca. Thanks to both @thearturca for @amnweb for their work in fixing and thoroughly testing these changes respectively. 9350792 fix(animation): added pending cancel count to track `is_cancelled` state 84ad947 refactor(animation): remove cancel idx decreasing 804b038 refactor(animation): remove `ANIMATION_TEMPORARILY_DISABLED` global vars f257873 fix(animation): extend cancelling system to support multiple cancel call dfd6e98 refactor(window): reuse window rect in `animate_position` method 18522db fix(animations): change check for existings animation to `pending_cancel_count` field Before it was checking `cancel_idx_counter` which is `id` counter. It never gonna equals `0` and doesn't represent all animations that running for that window. So it doesn't delete entry from hashmap. That leads to bug when border and stackbar doesn't get notified after animation ends.
|
Thanks! Squashed this into 3c03528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.