Use physical Z layer bounds to set nucleation volume in placeNuclei and associated unit test #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
reviewed
Jun 14, 2024
src/CAnucleation.hpp
Outdated
| @@ -142,6 +143,8 @@ struct Nucleation { | |||
| nuclei_x(n_event) = Kokkos::round((nuclei_x_unrounded - grid.x_min) / grid.deltax); | |||
| nuclei_y(n_event) = Kokkos::round((nuclei_y_unrounded - grid.y_min) / grid.deltax); | |||
| nuclei_z(n_event) = Kokkos::round((nuclei_z_unrounded - grid.z_min_layer[layernumber]) / grid.deltax); | |||
| std::cout << "Nuclei has " << nuclei_x(n_event) << ", " << nuclei_y(n_event) << ", " | |||
There was a problem hiding this comment.
Definitely was leftover from when I was debugging the unit test and wanted it to print out the locations of the nuclei
MattRolchigo
force-pushed
the
fixup_nucleation_layer
branch
from
74e8a52
to
9711cb8
Compare
streeve
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup of #355