Remove redundant simulation type check

[MattRolchigo]

Not sure how this got into the intermediate output subroutine to begin with, the simulation type only needs to be checked during the input read since it doesn't change at all during a run

[streeve]

I put it anywhere we pass the type, generally in case you weren't using the inputs directly. Is it worth it? I don't know, but there are two other places aside from the initial check during input parsing:

src/CAgrid.hpp: validSimulationType(simulation_type);
src/CAinputs.hpp: validSimulationType(simulation_type);
src/CAtemperature.hpp: validSimulationType(simulation_type);

[MattRolchigo]

It's not worth it - simulation type does not change once it is set in the constructor, if it's an invalid simulation type that should be caught during initialization but it doesn't need to be checked every time. Though I see why you did it, it would theoretically be possible to accidentally pass an std::string that was not simulation_type and cause an error

[streeve]

If there's ever a strange error because of a mistaken simulation type I will gloat

[MattRolchigo]

Fair enough, I felt good about this because the only times that we pass the problem type to a function, its the only input of type std::string so it won't get mixed up with another input for now