Code and example problem cleaup #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to comments to ensure they are up to date with the current code, also changed a couple of variable names for consistency with the current capitalization scheme, and changed a few std::cout messages.
Only changes to the actual code functionality are the two commits that are separated out - a portion of the powder layer init is skipped if the number of powder layer cells to be assigned grain ID values is 0 (this also avoids printing a confusing std::cout message about assigning cells non-existent powder layer grain IDs, and the translation increment in the two relevant example files was updated to ensure the temperature data actually overlaps.