Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Voronoi functionality between baseplate and powder init #372

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

MattRolchigo
Copy link
Collaborator

An edge case was previously possible in ExaCA where, due to the fact that the powder layer initialization left some cells with a "zero" GrainID, simulations of FromFile and FromFinch problems could get locked in a loop where no valid grain could claim the liquid cells in some melt pools for many time steps, often leading to simulation timeout. It also lead to unnatural grain shapes as grains stretch across multiple melt pools.

This changeset uses Voronoi helper functions to initialize both the baseplate (which previously used a Voronoi tessellation to assigned GrainIDs to cells) and each powder layer, so that no cells have a GrainID of 0 following initialization. The PowderDensity input is replaced with a MeanPowderGrainSize input, and for consistency, the MeanSize input is renamed MeanBaseplateGrainSize. Minor changes to the std::cout statements are also made to log which GrainID values are being used for which parts of the simulation (baseplate, powder layers, nucleated grains)

@MattRolchigo MattRolchigo added the bug Something isn't working label Aug 13, 2024
@streeve streeve self-requested a review August 13, 2024 15:13
src/CAinputs.hpp Outdated Show resolved Hide resolved
src/CAinputs.hpp Show resolved Hide resolved
src/CAinputs.hpp Show resolved Hide resolved
unit_test/tstInputs.hpp Show resolved Hide resolved
@MattRolchigo MattRolchigo merged commit 50929fd into LLNL:master Aug 28, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants