Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on setup.py and sub-module definition #29

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

gefei-qian-nih
Copy link

There are two places in setup.py that errored out.
One is about checking gcc compiler name. Noe parameter is needed in _is_gcc() call.
The other is on external library definition. libgmp was missed. This caused "memsurfer/_memsurfer_cmod.so: undefined symbol: __gmpq_add" error.
These two parts are corrected in setup.py.

In the .sub-module defination, an https link is used for anonymous download.

Instruction is provided to install dependencies with conda.

Adding links to cgal and gmp
Adding descriptions on conda way installation
Adding --recursive to the git clone
Adding a line of conda activate
@lunamorrow
Copy link

Hey @gefei-qian-nih. I'm trying to get memsurfer working. I've managed to install it a slightly different way, but with similar file changes to what you've done. Unfortunately, when I go to import the module from a test python file with python test.py and the memsurfer env activated, I receive this error:

Traceback (most recent call last):
  File "/home/user/Documents/Memsurfer_Setup/test.py", line 1, in <module>
    import memsurfer
  File "/home/user/Documents/Memsurfer_Setup/MemSurfer/memsurfer/__init__.py", line 15, in <module>
    from .membrane import Membrane
  File "/home/user/Documents/Memsurfer_Setup/MemSurfer/memsurfer/membrane.py", line 19, in <module>
    from pypoisson import poisson_reconstruction
ImportError: /home/user/Documents/Memsurfer_Setup/MemSurfer/pypoisson.so: undefined symbol: _Py_CheckRecursionLimit

Have you got any ideas? I cannot get into the SO file to figure out exactly whats going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants