Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in ECNF when rank not known #6301

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix error in ECNF when rank not known #6301

merged 1 commit into from
Dec 12, 2024

Conversation

roed314
Copy link
Contributor

@roed314 roed314 commented Dec 12, 2024 •
edited
Loading

Fixes #6300. Compare

self.ar was already typeset (so equaled \( 0 \)) triggering the try block inappropriately. Then the error was not an AttributeError, so was not caught.

@roed314 roed314 requested a review from JohnCremona December 12, 2024 03:33
@roed314 roed314 added the ECNF Elliptic curves over number fields other than Q label Dec 12, 2024
@edgarcosta edgarcosta merged commit 43460d3 into LMFDB:main Dec 12, 2024
13 checks passed
@JohnCremona
Copy link
Member

Thanks @roed314 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnCremona JohnCremona Awaiting requested review from JohnCremona

Assignees
No one assigned
Labels
ECNF Elliptic curves over number fields other than Q
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in ECNF when rank is not known
3 participants
@roed314 @JohnCremona @edgarcosta