update path information for several LOLBAS #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenoscr
reviewed
Oct 4, 2023
yml/OSBinaries/Teams.yml
Outdated
| @@ -12,7 +12,7 @@ Commands: | |||
| MitreID: T1218 | |||
| OperatingSystem: Windows 10, Windows 11 | |||
| Full_Path: | |||
| - Path: c:\Users\username\AppData\Local\Microsoft\Teams\current\Teams.exe | |||
| - Path: %localappdata%\Microsoft\Teams\current\Teams.exe | |||
There was a problem hiding this comment.
@ciwen3 this string is failing the YAML linting. The string cannot start with a "%" which is a reserved character that denotes a directive.
"Error: inaries/Teams.yml:15:11: [error] syntax error: found character '%' that cannot start any token (syntax)"
xenoscr
requested changes
Oct 4, 2023
There was a problem hiding this comment.
@ciwen3 Please review the comments, address the syntax issues and update your pull request. Once all checks are passing, we can merge your changes.
"Error: inaries/Teams.yml:15:11: [error] syntax error: found character '%' that cannot start any token (syntax)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added paths:
C:\Program Files\Windows Defender\MpCmdRun.exe
C:\Program Files (x86)\Microsoft\EdgeWebView\Application\117.0.2045.47\msedgewebview2.exe
C:\Windows\Microsoft.NET\Framework\v4.0.30319\vbc.exe
updated:
teams to have %localappdata% in the path
AgentExecutor added the exe name to the path to match all the other lolbas