Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaccoemuBaryons does not check for k or a ranges #1107

Open
tilmantroester opened this issue Jul 18, 2023 · 3 comments
Open

BaccoemuBaryons does not check for k or a ranges #1107

tilmantroester opened this issue Jul 18, 2023 · 3 comments
Assignees
Labels

Comments

@tilmantroester
Copy link
Contributor

I just tried BaccoemuBaryons but ran into a bunch of issues.

The following snipped fails with an opaque error, because the k and a ranges in https://github.com/LSSTDESC/CCL/blob/master/pyccl/baryons/baccoemu_baryons.py#L47 are never checked:

import numpy as np
import pyccl as ccl

bacco_emu = ccl.BaccoemuBaryons()
cosmo_bacco = ccl.CosmologyVanillaLCDM()
baryon_pk = bacco_emu.include_baryonic_effects(
    cosmo=cosmo_bacco, pk=cosmo_bacco.get_nonlin_power()
)

Installing baccoemu was quite painful as well. For one, the last release on pip is from 2021. Because it is not on conda, it tries to install a bunch of things from pip that was in conflict with my conda environment.

@damonge
Copy link
Collaborator

damonge commented Jul 18, 2023

@matteozennaro may be able to help

@damonge
Copy link
Collaborator

damonge commented Jul 18, 2023

In the meantime, this is what we do to install baccoemu in GHA: https://github.com/LSSTDESC/CCL/blob/86125b08f66b27341e9bb67403f3f0ca3cece359/.github/environment.yml#L19C1-L19C73

@tilmantroester
Copy link
Contributor Author

GHA seem to install numpy twice (https://github.com/LSSTDESC/CCL/actions/runs/5552350593/jobs/10139592538?pr=1103#step:8:255) as well, but due to class in that case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants