Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check a range on BaccoemuBaryons #1108

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Check a range on BaccoemuBaryons #1108

merged 6 commits into from
Jul 21, 2023

Conversation

tilmantroester
Copy link
Contributor

Quick fix for #1107. I haven't checked if that's an issue for the other emulators as well.

damonge
damonge reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just a couple of minor comments

pyccl/baryons/baccoemu_baryons.py Show resolved Hide resolved
pyccl/baryons/baccoemu_baryons.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5620206546

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.442%
Totals Coverage Status
Change from base Build 5619969593: 0.003%
Covered Lines: 5677
Relevant Lines: 5826
💛 - Coveralls

damonge
damonge approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tilmantroester tilmantroester merged commit de8127b into master Jul 21, 2023
@tilmantroester tilmantroester deleted the baccobaryons_a_check branch July 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilmantroester @coveralls @damonge