Create a parameter prefix for updatables #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the necessary calls to make the current Updatable implementation to pass sacc_tracer as the default parameter_prefix.
marcpaterno
reviewed
Sep 21, 2023
| def __init__(self, parameter_prefix: Optional[str] = None) -> None: | ||
| """Updatable initialization. | ||
|
|
||
| :param prefix: prefix for all parameters in this Updatable |
There was a problem hiding this comment.
We should fix the documentation so that it matches the argument name “parameter_prefix” (or change the code to match the comment).
marcpaterno
approved these changes
Sep 21, 2023
marcpaterno
deleted the
315-create-a-parameter_prefix-for-updatables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.