Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation for support m2 mac #337

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Update installation for support m2 mac #337

merged 7 commits into from
Oct 24, 2023

Conversation

marcpaterno
Copy link
Collaborator

This PR has many changes to the documentation and to the recommended development workflow. It includes now support for Apple Silicon (M1 and M2) Macs.

@marcpaterno marcpaterno requested a review from vitenti October 20, 2023 19:50
Copy link
Collaborator

@vitenti vitenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary question here is whether to recommend editable or strictly editable installations. In the second scenario, strict editable installations necessitate reinstallation whenever changes are applied but offer a closer simulation to a real installation.

python3 setup.py build
Note that we use the :bash:`--no-deps` flag to prevent the installation from accidentally taking in any new dependencies through :bash:`pip`.
If the installation fails because of the lack of a dependency, install that dependency using :bash:`conda` and not :bash:`pip`.
If you find a dpendency on a package not available through :bash:`conda` please file an issue on the issue tracker.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on dependency

docs/dev-notes.rst Show resolved Hide resolved
Minor typo correction.
@vitenti vitenti merged commit eb69f1d into master Oct 24, 2023
6 checks passed
@vitenti vitenti deleted the support-m2-mac branch October 24, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants