Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating constructiors for ready objects. #399

Merged
merged 53 commits into from
Apr 10, 2024
Merged

Creating constructiors for ready objects. #399

merged 53 commits into from
Apr 10, 2024

Conversation

marcpaterno
Copy link
Collaborator

This PR will be a step towards one-phase construction of Statistics and contained objects. This will eventually allow us to remove the read step, and thus simplify the construction of likelihoods.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (221cf65) to head (bcd54a5).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #399     +/-   ##
========================================
+ Coverage    95.5%   97.8%   +2.3%     
========================================
  Files          34      35      +1     
  Lines        2569    2989    +420     
========================================
+ Hits         2454    2926    +472     
+ Misses        115      63     -52     
Files Coverage Δ
firecrown/connector/cosmosis/likelihood.py 97.0% <100.0%> (+5.0%) ⬆️
...ood/gauss_family/statistic/source/number_counts.py 83.8% <100.0%> (+5.1%) ⬆️
...likelihood/gauss_family/statistic/source/source.py 100.0% <ø> (ø)
...hood/gauss_family/statistic/source/weak_lensing.py 92.7% <100.0%> (+7.5%) ⬆️
...own/likelihood/gauss_family/statistic/two_point.py 96.8% <100.0%> (+20.6%) ⬆️
firecrown/metadata/two_point.py 100.0% <100.0%> (ø)
firecrown/utils.py 100.0% <100.0%> (ø)

@vitenti vitenti marked this pull request as ready for review April 8, 2024 21:04
Remove "safe" serialization, add support for all Enum and InferredGalaxyZDist

Make TwoPoint serializable, add tests and fixtures

Add serialization for TwoPointCells

Fix wrongly-named function

Add serialization support for Window

Add method to test optional numpy arrays for equality

Add serialization for TwoPointCWindow

Add serialization to TwoPointXiTheta
@vitenti vitenti merged commit 5a344f4 into master Apr 10, 2024
10 checks passed
@vitenti vitenti deleted the twopoint_metadata branch April 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants