-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
408 following our planned roadmap we should cease support for python 39 #409
408 following our planned roadmap we should cease support for python 39 #409
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
========================================
- Coverage 97.8% 97.8% -0.1%
========================================
Files 35 35
Lines 2989 2982 -7
========================================
- Hits 2926 2919 -7
Misses 63 63
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove coveralls from the CI?
@@ -20,7 +20,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: ["ubuntu", "macos"] | |||
python-version: ["3.9", "3.10", "3.11"] | |||
python-version: ["3.10", "3.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not adding 3.12 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think it was good to add 3.12 to our workflows when we would still get an installation failure because of the unavailability of tensorflow. When that is solved I agree we should add it.
…d-cease-support-for-python-39
This will close #408