Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

408 following our planned roadmap we should cease support for python 39 #409

Conversation

marcpaterno
Copy link
Collaborator

This will close #408

@marcpaterno marcpaterno requested a review from vitenti April 12, 2024 01:32
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.8%. Comparing base (36b1125) to head (eb48349).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #409     +/-   ##
========================================
- Coverage    97.8%   97.8%   -0.1%     
========================================
  Files          35      35             
  Lines        2989    2982      -7     
========================================
- Hits         2926    2919      -7     
  Misses         63      63             
Files Coverage Δ
firecrown/connector/cobaya/ccl.py 100.0% <100.0%> (ø)
firecrown/connector/cobaya/likelihood.py 100.0% <ø> (ø)
firecrown/connector/mapping.py 100.0% <100.0%> (ø)
firecrown/connector/numcosmo/numcosmo.py 99.7% <100.0%> (ø)
firecrown/descriptors.py 100.0% <100.0%> (ø)
firecrown/likelihood/gauss_family/gauss_family.py 99.3% <100.0%> (ø)
...s_family/statistic/binned_cluster_number_counts.py 98.5% <100.0%> (-0.1%) ⬇️
...ood/gauss_family/statistic/source/number_counts.py 83.8% <100.0%> (ø)
...likelihood/gauss_family/statistic/source/source.py 100.0% <100.0%> (ø)
...hood/gauss_family/statistic/source/weak_lensing.py 92.7% <100.0%> (ø)
... and 13 more

Copy link
Collaborator

@vitenti vitenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove coveralls from the CI?

@@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
os: ["ubuntu", "macos"]
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.10", "3.11"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not adding 3.12 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think it was good to add 3.12 to our workflows when we would still get an installation failure because of the unavailability of tensorflow. When that is solved I agree we should add it.

@vitenti vitenti merged commit da0f250 into master Apr 16, 2024
7 checks passed
@vitenti vitenti deleted the 408-following-our-planned-roadmap-we-should-cease-support-for-python-39 branch April 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Following our planned roadmap, we should cease support for Python 3.9
2 participants